NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

chore: use go 1.18 everywhere in ci#641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

coadler merged 1 commit intomainfromcolin/more-1.18

Mar 29, 2022

Merged

chore: use go 1.18 everywhere in ci#641

coadler merged 1 commit intomainfromcolin/more-1.18

Mar 29, 2022

Conversation

Copy link

Contributor

coadler commentedMar 29, 2022

Somehow I missed these?

chore: use go 1.18 everywhere in ci

0aeeb32

Somehow I missed these?

coadler self-assigned this

Mar 29, 2022

kylecarbs approved these changes

Mar 29, 2022

View reviewed changes

Copy link

Member

kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Odd that it all worked........

coadlerenabled auto-merge (squash)

March 29, 2022 19:05

Copy link

codecovbot commentedMar 29, 2022

Codecov Report

Merging#641 (0aeeb32) intomain (1bab7e8) willdecrease coverage by0.43%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main     #641      +/-   ##==========================================- Coverage   64.53%   64.09%   -0.44%==========================================  Files         198      111      -87       Lines       11622    10547    -1075       Branches       85        0      -85     ==========================================- Hits         7500     6760     -740+ Misses       3333     3020     -313+ Partials      789      767      -22

Flag	Coverage Δ
unittest-go-	`63.47% <ø> (-0.14%)`	⬇️
unittest-go-macos-latest	`?`
unittest-go-ubuntu-latest	`62.15% <ø> (-0.05%)`	⬇️
unittest-go-windows-2022	`?`
unittest-js	`?`

Impacted Files	Coverage Δ
pty/start_other.go	`64.70% <0.00%> (-23.53%)`	⬇️
provisionersdk/transport.go	`78.72% <0.00%> (-6.39%)`	⬇️
cli/cliui/agent.go	`76.78% <0.00%> (-5.36%)`	⬇️
pty/ptytest/ptytest.go	`89.65% <0.00%> (-5.18%)`	⬇️
peer/conn.go	`77.15% <0.00%> (-4.83%)`	⬇️
cli/projectinit.go	`56.36% <0.00%> (-3.64%)`	⬇️
peerbroker/listen.go	`84.16% <0.00%> (-3.34%)`	⬇️
provisioner/echo/serve.go	`54.40% <0.00%> (-2.40%)`	⬇️
coderd/workspaceresources.go	`59.72% <0.00%> (-1.81%)`	⬇️
provisionerd/provisionerd.go	`79.44% <0.00%> (-1.62%)`	⬇️
... and90 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update1bab7e8...0aeeb32. Read thecomment docs.