Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: update templates to use rich parameters#6397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 36 commits intocoder:mainfrommatifali:rich-params-examples
Mar 15, 2023
Merged

chore: update templates to use rich parameters#6397

mtojek merged 36 commits intocoder:mainfrommatifali:rich-params-examples
Mar 15, 2023

Conversation

matifali
Copy link
Member

@matifalimatifali commentedMar 1, 2023•
edited by mtojek
Loading

After completion, this willresolve#6073
Contributes to#6075

  • do-linux
  • docker-image-builds
  • docker-with-dotfiles
  • docker-code-server
  • docker
  • gcp-linux
  • gcp-vm-container
  • gcp-windows
  • kubernetes
  • kubernetes-with-podman
  • aws-ecs-container
  • aws-linux
  • aws-windows
  • azure-linux

The checked are tested, and others are to be tested.

@matifalimatifali changed the titleupdate templates to use rich parameterschore: update templates to use rich parametersMar 1, 2023
Copy link
Member

@bpmctbpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you add checkboxes for each template we need to manually test? I can help with the cloud ones :)

@matifali
Copy link
MemberAuthor

matifali commentedMar 9, 2023•
edited
Loading

Can you add checkboxes for each template we need to manually test? I can help with the cloud ones :)

Done. Also, I removed all instances of terraformvariable. May I keep some items as managed variables?

@matifalimatifali marked this pull request as ready for reviewMarch 14, 2023 05:38
@matifali
Copy link
MemberAuthor

Hi@mtojek You may review the changes and provide your feedback. Feel free to directly push if you want to.

mtojek reacted with thumbs up emoji

@mtojekmtojek self-requested a reviewMarch 14, 2023 10:08
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Really good progress,@matifali! I left a few comments to address, but I think that this PR is in a really good shape.

matifali reacted with heart emoji
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I started testing templates and I will post spotted bugs.

matifali reacted with thumbs up emoji
@matifalimatifali requested review frommtojek and removed request formtojekMarch 14, 2023 17:08
@matifalimatifali requested a review frommtojekMarch 15, 2023 11:40
@mtojek
Copy link
Member

@matifali Could we extract thischange to a different pull-request? I wouldn't pack too much into this one, and I'd like to approve it.

matifali reacted with thumbs up emoji

@mtojekmtojek self-requested a reviewMarch 15, 2023 13:05
@matifali
Copy link
MemberAuthor

Yes, I agree. I have reverted. This is also not related to the current context.

Copy link
Member

@mtojekmtojek left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Templates were tested, and we fixed a couple of issues. I think that this PR is ready for merging 👍

Well done,@matifali, I appreciate your work on this. Let's keep an eye on template bug reports.

matifali reacted with heart emoji
@mtojekmtojekenabled auto-merge (squash)March 15, 2023 13:08
@matifali
Copy link
MemberAuthor

Thanks a lot,@mtojek for testing the templates and pointing out issues that I have missed.
Does theazure-vm template work? I mean there was confusion about region names.

@mtojekmtojek merged commita0e096b intocoder:mainMar 15, 2023
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 15, 2023
@mtojek
Copy link
Member

Does the azure-vm template work? I mean there was confusion about region names.

Let me check some of those which changed.

@mtojek
Copy link
Member

Yup, no issues. I checked: Qatar Central, Switzerland North, and UAE North

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs left review comments

@bpmctbpmctbpmct left review comments

@mtojekmtojekmtojek approved these changes

Assignees

@matifalimatifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rich parameters: convert Coder examples
4 participants
@matifali@mtojek@bpmct@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp