Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix!: replace owner_email with workspace_owner, change action to workspace_transition#6337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit intomainfromcj/fixup-prom-owner-email
Feb 24, 2023

Conversation

@johnstcn
Copy link
Member

@johnstcnjohnstcn commentedFeb 24, 2023•
edited
Loading

  • owner_email is problematic because prom replaces @ with _. Replacing with username (workspace_owner)
  • action -> workspace_transition for consistency

Fixes#6335.

@johnstcnjohnstcn requested a review froma teamFebruary 24, 2023 04:04
@johnstcnjohnstcn self-assigned thisFeb 24, 2023
@johnstcnjohnstcn requested review fromdeansheather and removed request fora teamFebruary 24, 2023 04:04
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM but this needs to be marked breaking by adding a! to the PR title (fix!: ...) and adding therelease/breaking label

@johnstcnjohnstcn changed the titlefix: replace owner_email with workspace_owner, change action to workspace_transitionfix!: replace owner_email with workspace_owner, change action to workspace_transitionFeb 24, 2023
@johnstcnjohnstcn added the release/breakingThis label is applied to PRs to detect breaking changes as part of the release process labelFeb 24, 2023
@johnstcn
Copy link
MemberAuthor

LGTM but this needs to be marked breaking by adding a! to the PR title (fix!: ...) and adding therelease/breaking label

Done, but is this necessary even if the changed behaviour is not yet in any published release?

@johnstcnjohnstcn merged commit473ab20 intomainFeb 24, 2023
@johnstcnjohnstcn deleted the cj/fixup-prom-owner-email branchFebruary 24, 2023 04:39
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 24, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@johnstcnjohnstcn

Labels

release/breakingThis label is applied to PRs to detect breaking changes as part of the release process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: prometheus: user_host.tld logged instead of user@host.tld

3 participants

@johnstcn@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp