Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add support forcoder_git_auth data source#6334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 21 commits intomainfromgitauth
Feb 27, 2023
Merged

Conversation

kylecarbs
Copy link
Member

@kylecarbskylecarbs commentedFeb 24, 2023
edited
Loading

This allows template authors to force Git authentication on workspace creation. It doesnot provide guarantees of Git authentication on subsequent builds at the moment, but that might change before merge.

TODO:

  • Add validation for Git authentication in the workspace build API
  • Add prompts in the CLI for authenticating with Git

Update: I'll be adding support for forcing Git authentication during workspace builds once the startup script work@code-asher is working on is merged. Otherwise, it becomes a bit awkward.

I wasn't able to find a fantastic way to decompose this PR into smaller chunks. This only affects users that add thecoder_git_auth block to their templates!

@kylecarbskylecarbs self-assigned thisFeb 24, 2023
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Left a few comments, but nothing really concerning.

@kylecarbskylecarbs merged commit7f226d4 intomainFeb 27, 2023
@kylecarbskylecarbs deleted the gitauth branchFebruary 27, 2023 16:18
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@mtojekmtojekmtojek approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kylecarbs@BrunoQuaresma@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp