NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

fix: change dev tunnel default back to true#630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

f0ssel merged 1 commit intomainfromf0ssel/fix-dev-tunnel-default

Mar 28, 2022

Merged

fix: change dev tunnel default back to true#630

f0ssel merged 1 commit intomainfromf0ssel/fix-dev-tunnel-default

Mar 28, 2022

Conversation

Copy link

Contributor

f0ssel commentedMar 28, 2022•
edited
Loading

Changing it originally was an accident

fix: change dev tunnel default back to true

2ed17b8

f0ssel requested review fromkylecarbs andcoadler

March 28, 2022 22:08

kylecarbs approved these changes

Mar 28, 2022

View reviewed changes

f0sselenabled auto-merge (squash)

March 28, 2022 22:08

Copy link

codecovbot commentedMar 28, 2022•
edited
Loading

Codecov Report

Merging#630 (2ed17b8) intomain (e0172dd) willdecrease coverage by0.22%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main     #630      +/-   ##==========================================- Coverage   63.83%   63.60%   -0.23%==========================================  Files         197      111      -86       Lines       11537    10464    -1073       Branches       85        0      -85     ==========================================- Hits         7365     6656     -709+ Misses       3397     3060     -337+ Partials      775      748      -27

Flag	Coverage Δ
unittest-go-	`62.97% <100.00%> (+0.14%)`	⬆️
unittest-go-macos-latest	`58.44% <100.00%> (-0.03%)`	⬇️
unittest-go-ubuntu-latest	`61.36% <100.00%> (-0.24%)`	⬇️
unittest-go-windows-2022	`?`
unittest-js	`?`

Impacted Files	Coverage Δ
cli/start.go	`64.17% <100.00%> (ø)`
provisionersdk/serve.go	`35.13% <0.00%> (-8.11%)`	⬇️
pty/ptytest/ptytest.go	`94.82% <0.00%> (-5.18%)`	⬇️
cli/projectinit.go	`56.36% <0.00%> (-3.64%)`	⬇️
peerbroker/listen.go	`83.89% <0.00%> (-3.39%)`	⬇️
peer/conn.go	`76.14% <0.00%> (-3.30%)`	⬇️
coderd/parameter/compute.go	`74.07% <0.00%> (-2.23%)`	⬇️
provisionerd/provisionerd.go	`79.88% <0.00%> (-1.18%)`	⬇️
provisioner/echo/serve.go	`56.80% <0.00%> (ø)`
site/src/components/Icons/WorkspacesIcon.tsx
... and87 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatee0172dd...2ed17b8. Read thecomment docs.