Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: update to go 1.18#628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
coadler merged 6 commits intomainfromcolin/go1.18
Mar 28, 2022
Merged

chore: update to go 1.18#628

coadler merged 6 commits intomainfromcolin/go1.18
Mar 28, 2022

Conversation

coadler
Copy link
Contributor

No description provided.

@coadlercoadler self-assigned thisMar 28, 2022
@codecov
Copy link

codecovbot commentedMar 28, 2022•
edited
Loading

Codecov Report

Merging#628 (ce4039a) intomain (eb18925) willdecrease coverage by0.23%.
The diff coverage is91.66%.

@@            Coverage Diff             @@##             main     #628      +/-   ##==========================================- Coverage   63.53%   63.29%   -0.24%==========================================  Files         195      112      -83       Lines       11215    10432     -783       Branches       85        0      -85     ==========================================- Hits         7125     6603     -522+ Misses       3334     3079     -255+ Partials      756      750       -6
FlagCoverage Δ
unittest-go-62.42% <91.66%> (+0.25%)⬆️
unittest-go-macos-latest58.14% <66.66%> (-0.18%)⬇️
unittest-go-ubuntu-latest61.19% <66.66%> (+0.01%)⬆️
unittest-go-windows-202257.35% <66.66%> (+0.22%)⬆️
unittest-js?
Impacted FilesCoverage Δ
codersdk/client.go50.64% <ø> (-5.20%)⬇️
cli/cliui/select.go45.71% <66.66%> (+1.96%)⬆️
coderd/database/pubsub.go77.77% <100.00%> (+0.69%)⬆️
coderd/provisionerjobs.go61.92% <100.00%> (+1.92%)⬆️
codersdk/workspacebuilds.go58.33% <0.00%> (-8.34%)⬇️
peerbroker/dial.go75.43% <0.00%> (-7.02%)⬇️
coderd/workspacebuilds.go55.31% <0.00%> (-6.39%)⬇️
provisionersdk/transport.go74.46% <0.00%> (-6.39%)⬇️
peer/conn.go76.64% <0.00%> (-4.07%)⬇️
... and98 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateeb18925...ce4039a. Read thecomment docs.

@coadlercoadler marked this pull request as ready for reviewMarch 28, 2022 18:55
@coadlercoadler requested a review fromkylecarbsMarch 28, 2022 18:56
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just two minor nits. Hello generics!

@coadlercoadlerenabled auto-merge (squash)March 28, 2022 19:08
@coadlercoadler merged commitbe8389f intomainMar 28, 2022
@coadlercoadler deleted the colin/go1.18 branchMarch 28, 2022 19:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

Assignees

@coadlercoadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@coadler@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp