Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(site): Upload template files on template version editor#6222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 6 commits intomainfromfix/upload-template-files
Feb 16, 2023

Conversation

@BrunoQuaresma
Copy link
Contributor

@BrunoQuaresmaBrunoQuaresma commentedFeb 15, 2023
edited
Loading

How to QA:

  • Go to any template, preferably a template you can break.
  • At the bottom, select a version
  • Click on the edit button or add/edit at the end of the URL
  • Edit any file, preferably with a comment, and build it
  • If that works as expected - with a success message - the goal was achieved.
  • You can also navigate back to the template page and access the latest version created by you, click on edit, and check if all the changes you made are still there.

Strategy

  • The strategy was to append all the non-supported files in the tar first and after, add the ones from the editor file tree. Why? By doing that, we can rely on the file tree to append or not the editable files.
  • I'm also planning to remove untar dependency to use the util we have, but probably it is also going to be done in a next PR

Testing
Instead of testing the entire flow, I can try to extract the "update template version files" to test only this in isolation. I don't know how hard is but it sounds valuable. I'm probably going to do that in the next PR.

@BrunoQuaresma
Copy link
ContributorAuthor

I tested:

  • Create a new file
  • Create a new folder
  • Delete a folder
  • Delete a file

It is broken:

  • Rename is broken but I'm working to fix that on this PR or in the next one since are different issues

@BrunoQuaresma
Copy link
ContributorAuthor

Fix#6217

@BrunoQuaresmaBrunoQuaresma merged commit909fbb6 intomainFeb 16, 2023
@BrunoQuaresmaBrunoQuaresma deleted the fix/upload-template-files branchFebruary 16, 2023 16:59
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@code-ashercode-asherAwaiting requested review from code-asher

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrunoQuaresma@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp