NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

fix: Improve closure of provisioner and agent tailnet dial#6199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mafredri merged 7 commits intomainfrommafredri/fix-provisioner-closures

Feb 14, 2023

Merged

fix: Improve closure of provisioner and agent tailnet dial#6199

mafredri merged 7 commits intomainfrommafredri/fix-provisioner-closures

Feb 14, 2023

Conversation

Copy link

Member

mafredri commentedFeb 14, 2023

These came up when trying to dig into#6198 and the following:

goleak: Errors on successful test run: found unexpected goroutines:[Goroutine 10 in state chan receive, with storj.io/drpc/drpcserver.(*Server).Serve.func1 on top of the stack:goroutine 10 [chan receive]:storj.io/drpc/drpcserver.(*Server).Serve.func1({0xc3eea0?, 0xc0004641b0?})/home/mafredri/.local/go/pkg/mod/storj.io/drpc@v0.0.33-0.20220622181519-9206537a4db7/drpcserver/server.go:80 +0x45storj.io/drpc/drpcctx.(*Tracker).track(0xc0004641b0, 0x0?)/home/mafredri/.local/go/pkg/mod/storj.io/drpc@v0.0.33-0.20220622181519-9206537a4db7/drpcctx/transport.go:52 +0x2bcreated by storj.io/drpc/drpcctx.(*Tracker).Run/home/mafredri/.local/go/pkg/mod/storj.io/drpc@v0.0.33-0.20220622181519-9206537a4db7/drpcctx/transport.go:47 +0x8d Goroutine 9 in state chan receive, with github.com/valyala/fasthttp/fasthttputil.(*InmemoryListener).Accept on top of the stack:goroutine 9 [chan receive]:github.com/valyala/fasthttp/fasthttputil.(*InmemoryListener).Accept(0xc0004641b0?)/home/mafredri/.local/go/pkg/mod/github.com/valyala/fasthttp@v1.44.0/fasthttputil/inmemory_listener.go:50 +0x35storj.io/drpc/drpcserver.(*Server).Serve(0xc0004aa000, {0xc3e810, 0xc00015a000}, {0xc3d230?, 0xc000122000})/home/mafredri/.local/go/pkg/mod/storj.io/drpc@v0.0.33-0.20220622181519-9206537a4db7/drpcserver/server.go:85 +0x1bbgithub.com/coder/coder/provisionerd_test.createProvisionerDaemonClient.func3()/home/mafredri/src/coder/coder/provisionerd/provisionerd_test.go:1096 +0x6ccreated by github.com/coder/coder/provisionerd_test.createProvisionerDaemonClient/home/mafredri/src/coder/coder/provisionerd/provisionerd_test.go:1094 +0x485]