Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Clean up conn on NewStream error in memDRPC#6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedFeb 13, 2023•
edited
Loading

If we don't close the connections, we'll leak memory/leave connections open.

@mafredrimafredri self-assigned thisFeb 13, 2023
@mafredrimafredriforce-pushed themafredri/fix-provisionersdk-memdrpc-stream-close branch from2daf091 toe70d1dfCompareFebruary 13, 2023 14:27
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! Could you please add a short writeup to the issue description, so that it's clear why is it necessary?

@mafredri
Copy link
MemberAuthor

Hey! Could you please add a short writeup to the issue description, so that it's clear why is it necessary?

Done 👍🏻.

@mtojek
Copy link
Member

mtojek commentedFeb 13, 2023•
edited
Loading

Ok, that's what I expected. Is there any issue that should be linked or did you find it accidentally?

@mafredri
Copy link
MemberAuthor

CI failure, was an easy fix so I didn't open an issue for it.

mtojek reacted with thumbs up emoji

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM if it helps 👍

mafredri reacted with hooray emoji
@mafredrimafredri merged commit2157bff intomainFeb 13, 2023
@mafredrimafredri deleted the mafredri/fix-provisionersdk-memdrpc-stream-close branchFebruary 13, 2023 15:27
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek approved these changes

@coadlercoadlerAwaiting requested review from coadler

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mafredri@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp