- Notifications
You must be signed in to change notification settings - Fork1.1k
feat(agent): Add shutdown lifecycle states and shutdown_script support#6139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
49f04ad toa1222d0Comparemafredri commentedFeb 13, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
mtojek left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
LGTM, but I didn't analyze it too deeply as the PR is massive.
2ac1a38 to2ca1810CompareThis Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
mtojek commentedMar 6, 2023
Hey@mafredri! Is it something that you will continue to work soon? |
mafredri commentedMar 6, 2023
Yup, I'll get this rebased and (try to) merge it today. 👍🏻 |
2ca1810 to22ad8b9Compareshutdown_script support
Uh oh!
There was an error while loading.Please reload this page.
This PR adds support for agent shutdown lifecycle states and
shutdown_script.It (currently) relies on terraform provider abilities to gracefully shut down. For instance with the docker provider it can be controlled via:
The agent can handle common signals like
SIGHUP,SIGINT,SIGTERM. If need be, more signals could be handled.Builds upon#5171
Fixes#4677
Note:
stopping,stop_timeout,stop_error,stopped, yay or nay to make this change?