Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(agent): Add shutdown lifecycle states and shutdown_script support#6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 21 commits intomainfrommafredri/feat-shutdown-script
Mar 6, 2023

Conversation

@mafredri
Copy link
Member

@mafredrimafredri commentedFeb 9, 2023
edited
Loading

This PR adds support for agent shutdown lifecycle states andshutdown_script.

It (currently) relies on terraform provider abilities to gracefully shut down. For instance with the docker provider it can be controlled via:

resource"docker_container""workspace" {destroy_grace_seconds=30stop_timeout=30stop_signal="SIGINT"}

The agent can handle common signals likeSIGHUP,SIGINT,SIGTERM. If need be, more signals could be handled.

Builds upon#5171
Fixes#4677

Note:

  • In hindsight, I should probably have called the lifecycle statesstopping,stop_timeout,stop_error,stopped, yay or nay to make this change?

@mafredri
Copy link
MemberAuthor

mafredri commentedFeb 13, 2023
edited
Loading

TODOs (a1222d0) have been removed in favor of#6180 (primarily#6177).

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice!

LGTM, but I didn't analyze it too deeply as the PR is massive.

@mafredrimafredriforce-pushed themafredri/feat-shutdown-script branch from2ac1a38 to2ca1810CompareFebruary 20, 2023 13:35
@kylecarbskylecarbs removed their request for reviewFebruary 26, 2023 18:05
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelMar 6, 2023
@mtojek
Copy link
Member

Hey@mafredri! Is it something that you will continue to work soon?

@mafredri
Copy link
MemberAuthor

Hey@mafredri! Is it something that you will continue to work soon?

Yup, I'll get this rebased and (try to) merge it today. 👍🏻

mtojek and kylecarbs reacted with thumbs up emoji

@mafredrimafredriforce-pushed themafredri/feat-shutdown-script branch from2ca1810 to22ad8b9CompareMarch 6, 2023 12:04
@mafredrimafredri removed the staleThis issue is like stale bread. labelMar 6, 2023
@mafredrimafredri changed the titlefeat(agent): Add shutdown lifecycle states andshutdown_script supportfeat(agent): Add shutdown lifecycle states and shutdown_script supportMar 6, 2023
@mafredrimafredri merged commit22e3ff9 intomainMar 6, 2023
@mafredrimafredri deleted the mafredri/feat-shutdown-script branchMarch 6, 2023 19:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mtojekmtojekmtojek approved these changes

Assignees

@mafredrimafredri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run script before workspace stop

3 participants

@mafredri@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp