Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

helm: add deployment securityContext values#6136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ericpaulsen merged 2 commits intomainfromsecuritycontexts
Feb 9, 2023

Conversation

ericpaulsen
Copy link
Member

@ericpaulsenericpaulsen commentedFeb 9, 2023
edited
Loading

this PR adds support for configuring the Coder deployment'ssecurityContext (for both pod & container) in the values file. this comes in handy when deploying Coder on OpenShift, which appliesSecurityContextConstraints to deployments.

one question i have - since the Coder deployment consists of a single container, is it necessary for us to have a pod-levelsecurityContext? thesecurityContext set at the container-level takes precedence over the pod-level context.

keeping thepodSecurityContext values is beneficial if there is any possibility of us adding containers to the deployment. otherwise, I don't see much a reason to keep it.

@ericpaulsenericpaulsen merged commit22f6400 intomainFeb 9, 2023
@ericpaulsenericpaulsen deleted the securitycontexts branchFebruary 9, 2023 18:26
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 9, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ericpaulsenericpaulsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ericpaulsen@johnstcn@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp