Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add ability to deploy extra k8s yamls with helm chart#5942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 3 commits intocoder:mainfrommh013370:add-extra-deploy
Feb 3, 2023

Conversation

mh013370
Copy link
Contributor

This PR adds the ability to deploy extra k8s yamls alongside a Coder deployment in k8s. This is useful for creating secrets/configmaps that get mounted into the Coder pod(s).

Tested by running it through helm template:

command > helm template app helm/ --dry-run --debug --set coder.image.tag=test...---# Source: coder/templates/extra-deploy.yamlapiVersion: v1data:  key: valuekind: ConfigMapmetadata:  name: my-configmap...

@mh013370mh013370 changed the titleadd ability to deploy extra k8s yamls with helm chartfeat: add ability to deploy extra k8s yamls with helm chartFeb 1, 2023
@mh013370
Copy link
ContributorAuthor

Since i'm adding new optional configuration, i don't believe the failures are due to my changes in this PR.

@deansheatherdeansheather self-requested a reviewFebruary 3, 2023 08:13
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, I'll test this out locally in a moment and approve the PR.

@deansheatherdeansheatherenabled auto-merge (squash)February 3, 2023 17:18
@deansheatherdeansheather merged commit2285a5e intocoder:mainFeb 3, 2023
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 3, 2023
@mh013370mh013370 deleted the add-extra-deploy branchFebruary 4, 2023 15:16
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mh013370@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp