Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add iron bank Dockerfile & manifest#5934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ericpaulsen merged 13 commits intomainfromiron-bank
Feb 7, 2023
Merged

Conversation

ericpaulsen
Copy link
Member

adds Iron Bank-compatible Dockerfile & hardening manifest. this will be the master copy that we will copy into the Iron Bank repo.

Co-authored-by: Dean Sheather <dean@deansheather.com>
kylecarbs
kylecarbs previously requested changesJan 31, 2023
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't want this to be a top-level folder. Let's put it inside ofscripts.

ericpaulsen reacted with thumbs up emoji
@deansheather
Copy link
Member

scripts doesn't seem appropriate as there are no scripts, but we don't have adeploy folder like v1....

@kylecarbs
Copy link
Member

@deansheather I don't think there's a point in creating a new folder type for this because it's so bespoke.

deansheather and ericpaulsen reacted with thumbs up emoji

@ericpaulsen
Copy link
MemberAuthor

prettier is returning the following error:

site/src/components/AuthProvider/AuthProvider.tsx[error] site/src/components/AuthProvider/AuthProvider.tsx: SyntaxError: '>' expected. (23:18)[error]   21 |[error]   22 | type UseAuthReturnType = ReturnType<[error] > 23 |   typeof useActor<AuthContextValue["authService"]>[error]      |                  ^[error]   24 | >[error]   25 |[error]   26 | export const useAuth = (): UseAuthReturnType => {

@deansheather let me know the best path forward to resolve.

@deansheather
Copy link
Member

@ericpaulsen I'd try checking outmain, pulling, then checkout the PR branch again and dogit merge main to update the branch since it's not a file you touched

ericpaulsen reacted with thumbs up emoji

@deansheather
Copy link
Member

We should merge this even with all of the vulnerabilities reported by trivy, and focus on fixing them after merge. Some of them are vulnerabilities in the base image which we might not be able to resolve.

@ericpaulsenericpaulsen dismissedkylecarbs’sstale reviewFebruary 7, 2023 22:59

the requested changes were made.

@ericpaulsenericpaulsen merged commitf24547e intomainFeb 7, 2023
@ericpaulsenericpaulsen deleted the iron-bank branchFebruary 7, 2023 23:09
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 7, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather left review comments

@sreyasreyasreya approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Labels
enterpriseEnterprise-license / premium functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ericpaulsen@deansheather@kylecarbs@sreya
[8]ページ先頭
©2009-2025 Movatter.jp