- Notifications
You must be signed in to change notification settings - Fork928
feat: Support rich parameters in autobuilds#5916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
6fcf970 to5954844Compare| } | ||
| return nil | ||
| return store.InTx(func(db database.Store) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure this is strictly necessary as each workspace is processed in its own transaction (see #L132)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm rather thinking about the case when it inserts a record to the workspace table, but it fails to insert parameters for some reason. In this case, it's better to rollback the entire transaction.
Related:#5574
This PR enables support for rich parameters in autobuilds. I didn't notice that the build logic isduplicated.