NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

chore: Add helper for uniform flags and env vars#588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

f0ssel merged 5 commits intomainfromf0ssel/env

Mar 28, 2022

Merged

chore: Add helper for uniform flags and env vars#588

f0ssel merged 5 commits intomainfromf0ssel/env

Mar 28, 2022

Conversation

Copy link

Contributor

f0ssel commentedMar 27, 2022

This is a small package dedicated to cleaning and standardizing flags on the cli. By doing so we gain:

Default values for flags
Enforces pattern of matching flags and env vars (and requiring env vars use flags so we have better tests)
Generates clean usage docs for flags that have env var fallbacks & defaults

f0ssel force-pushed thef0ssel/env branch 2 times, most recently fromda08c31 tob949d1aCompare

March 28, 2022 00:00

Copy link

codecovbot commentedMar 28, 2022•
edited
Loading

Codecov Report

Merging#588 (13c71df) intomain (b33dec9) willdecrease coverage by0.25%.
The diff coverage is96.87%.

@@            Coverage Diff             @@##             main     #588      +/-   ##==========================================- Coverage   63.68%   63.43%   -0.26%==========================================  Files         195      196       +1       Lines       11313    11323      +10       Branches       85       85              ==========================================- Hits         7205     7183      -22- Misses       3351     3378      +27- Partials      757      762       +5

Flag	Coverage Δ
unittest-go-	`62.50% <96.87%> (-0.20%)`	⬇️
unittest-go-macos-latest	`58.39% <96.87%> (+0.10%)`	⬆️
unittest-go-ubuntu-latest	`61.33% <96.87%> (-0.01%)`	⬇️
unittest-go-windows-2022	`57.35% <96.87%> (-0.03%)`	⬇️
unittest-js	`63.32% <ø> (ø)`

Impacted Files	Coverage Δ
cli/workspaceagent.go	`66.66% <66.66%> (ø)`
cli/cliflag/cliflag.go	`100.00% <100.00%> (ø)`
cli/start.go	`63.80% <100.00%> (-1.97%)`	⬇️
provisionersdk/transport.go	`74.46% <0.00%> (-6.39%)`	⬇️
codersdk/provisionerdaemons.go	`58.46% <0.00%> (-3.08%)`	⬇️
coderd/provisionerdaemons.go	`60.23% <0.00%> (-2.52%)`	⬇️
peer/conn.go	`79.18% <0.00%> (-1.53%)`	⬇️
provisionerd/provisionerd.go	`79.73% <0.00%> (-1.18%)`	⬇️
peer/channel.go	`83.62% <0.00%> (+0.58%)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb33dec9...13c71df. Read thecomment docs.