Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Add UI for awaiting agent connections#578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 14 commits intomainfromssh
Mar 29, 2022
Merged
Show file tree
Hide file tree
Changes from1 commit
Commits
Show all changes
14 commits
Select commitHold shift + click to select a range
7ed283c
feat: Add stage to build logs
kylecarbsMar 26, 2022
048f29a
feat: Add stage to build logs
kylecarbsMar 26, 2022
2152758
feat: Add config-ssh and tests for resiliency
kylecarbsMar 27, 2022
e774dd7
Merge branch 'nicerlogs' into ssh
kylecarbsMar 27, 2022
172d4fe
Rename "Echo" test to "ImmediateExit"
kylecarbsMar 27, 2022
82f60db
Fix Terraform resource agent association
kylecarbsMar 27, 2022
6bff973
Fix logs post-cancel
kylecarbsMar 27, 2022
3654022
Fix select on Windows
kylecarbsMar 28, 2022
aef12e1
Remove terraform init logs
kylecarbsMar 28, 2022
15cae15
Move timer into it's own loop
kylecarbsMar 28, 2022
fb9fbb6
Fix race condition in provisioner jobs
kylecarbsMar 28, 2022
c91b3cc
Merge branch 'main' into ssh
kylecarbsMar 28, 2022
9ad326b
Merge branch 'main' into ssh
kylecarbsMar 28, 2022
342b03d
Fix requested changes
kylecarbsMar 29, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Remove terraform init logs
  • Loading branch information
@kylecarbs
kylecarbs committedMar 28, 2022
commitaef12e1117d30daa73fba80d88c840473e9e763f
51 changes: 26 additions & 25 deletionscli/cliui/provisionerjob.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,9 +22,6 @@ func WorkspaceBuild(cmd *cobra.Command, client *codersdk.Client, build uuid.UUID
build, err := client.WorkspaceBuild(cmd.Context(), build)
return build.Job, err
},
Cancel: func() error {
return client.CancelWorkspaceBuild(cmd.Context(), build)
},
Logs: func() (<-chan codersdk.ProvisionerJobLog, error) {
return client.WorkspaceBuildLogsAfter(cmd.Context(), build, before)
},
Expand DownExpand Up@@ -104,29 +101,31 @@ func ProvisionerJob(cmd *cobra.Command, opts ProvisionerJobOptions) error {
}
updateJob()

// Handles ctrl+c to cancel a job.
stopChan := make(chan os.Signal, 1)
defer signal.Stop(stopChan)
go func() {
signal.Notify(stopChan, os.Interrupt)
select {
case <-ctx.Done():
return
case _, ok := <-stopChan:
if !ok {
if opts.Cancel != nil {
// Handles ctrl+c to cancel a job.
stopChan := make(chan os.Signal, 1)
defer signal.Stop(stopChan)
go func() {
signal.Notify(stopChan, os.Interrupt)
select {
case <-ctx.Done():
return
case _, ok := <-stopChan:
if !ok {
return
}
}
}
//Stop listening for signals so another one kills it!
signal.Stop(stopChan)
_, _ = fmt.Fprintf(cmd.OutOrStdout(), "\033[2K\r\n"+Styles.FocusedPrompt.String()+Styles.Bold.Render("Gracefully canceling... wait for exit or data loss may occur!")+"\n\n")
err:= opts.Cancel()
if err != nil {
errChan <- xerrors.Errorf("cancel: %w", err)
return
}
updateJob()
}()
// Stop listening for signals so another one kills it!
signal.Stop(stopChan)
_, _ = fmt.Fprintf(cmd.OutOrStdout(), "\033[2K\r\n"+Styles.FocusedPrompt.String()+Styles.Bold.Render("Gracefully canceling...")+"\n\n")
err := opts.Cancel()
iferr!= nil {
errChan <- xerrors.Errorf("cancel: %w", err)
return
}
updateJob()
}()
}

logs, err := opts.Logs()
if err != nil {
Expand DownExpand Up@@ -165,7 +164,9 @@ func ProvisionerJob(cmd *cobra.Command, opts ProvisionerJobOptions) error {
}
output := ""
switch log.Level {
case database.LogLevelTrace, database.LogLevelDebug, database.LogLevelError:
case database.LogLevelDebug:
continue
case database.LogLevelTrace, database.LogLevelError:
output = defaultStyles.Error.Render(log.Output)
case database.LogLevelWarn:
output = Styles.Warn.Render(log.Output)
Expand Down
2 changes: 1 addition & 1 deletionprovisioner/terraform/provision.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,7 +80,7 @@ func (t *terraform) Provision(stream proto.DRPCProvisioner_ProvisionStream) erro
_ = stream.Send(&proto.Provision_Response{
Type: &proto.Provision_Response_Log{
Log: &proto.Log{
Level: proto.LogLevel_INFO,
Level: proto.LogLevel_DEBUG,
Output: scanner.Text(),
},
},
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp