Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Pre-fill param inputs with query string values#5758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

Close#5671

@BrunoQuaresmaBrunoQuaresma self-assigned thisJan 17, 2023
@BrunoQuaresmaBrunoQuaresma requested a review froma team as acode ownerJanuary 17, 2023 19:18
@BrunoQuaresmaBrunoQuaresma requested review fromcode-asher and removed request fora teamJanuary 17, 2023 19:18
Copy link
Member

@code-ashercode-asher left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Works great!One thing I noticed is that in the create form we label the fieldsvar.{name} and in the URL it usesparam.{name}, is that OK? I am not super familiar with Terraform vars so this might make sense. all good, see below

@code-asher
Copy link
Member

code-asher commentedJan 17, 2023•
edited
Loading

Nevermind, I see this was discussed in the original issue. Looks good!

@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)January 17, 2023 22:08
@BrunoQuaresmaBrunoQuaresma merged commita13614e intomainJan 17, 2023
@BrunoQuaresmaBrunoQuaresma deleted the bq/support-pre-fill-parmas-for-workspace-page branchJanuary 17, 2023 22:56
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@code-ashercode-ashercode-asher approved these changes

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre-fill template parameters with URL query params
2 participants
@BrunoQuaresma@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp