- Notifications
You must be signed in to change notification settings - Fork928
feat: PGP sign the checksum file in releases#5757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
| @@ -214,6 +214,7 @@ jobs: | |||
| ./build/*.rpm | |||
| env: | |||
| GITHUB_TOKEN:${{ secrets.GITHUB_TOKEN }} | |||
| CODER_GPG_RELEASE_KEY_BASE64:${{ secrets.CODER_GPG_RELEASE_KEY_BASE64 }} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just curious, why base64 vs armored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's armoredand base64'd. Base64'd mostly so it's on a single line. It's not necessary, but avoids any weird escaping issues if they ever crop up in the future.
Uh oh!
There was an error while loading.Please reload this page.
Just realized I didn't see if we upload the file as well, or is it automatic as part of all-files-in-a-dir? |
Yep, the publish script automatically uploads all files in |
Adds
coder_${version}_checksums.txt.ascto releases. Signed with the release key, for which the public key can be found inrelease.key.Kyle made the key and added it to GitHub Actions secrets. He will be adding it to 1password and sharing it with Ammar so we don't lose it and it stays secure.