NotificationsYou must be signed in to change notification settings
Fork929
Star10.1k

feat: Support caching provisioner assets#574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kylecarbs merged 5 commits intomainfromplugincache

Mar 28, 2022

Merged

feat: Support caching provisioner assets#574

kylecarbs merged 5 commits intomainfromplugincache

Mar 28, 2022

Conversation

Copy link

Member

kylecarbs commentedMar 26, 2022

This caches the Terraform binary, and Terraform plugins.
Eventually, it could cache other temporary files.

feat: Add AWS instance identity authentication

c31d9cd

This allows zero-trust authentication for all AWS instances.Prior to this, AWS instances could be used by passing `CODER_TOKEN`as an environment variable to the startup script. AWS explicitlystates that secrets should not be passed in startup scripts becauseit's user-readable.

kylecarbs requested a review fromcoadler

March 26, 2022 05:04

kylecarbs self-assigned this

Mar 26, 2022

feat: Support caching provisioner assets

87cd77c

This caches the Terraform binary, and Terraform plugins.Eventually, it could cache other temporary files.

kylecarbs force-pushed theplugincache branch from83924a7 to87cd77cCompare

March 26, 2022 05:07

Copy link

codecovbot commentedMar 26, 2022•
edited
Loading

Codecov Report

Merging#574 (04d9fe3) intomain (a502a5f) willdecrease coverage by0.20%.
The diff coverage is44.44%.

@@            Coverage Diff             @@##             main     #574      +/-   ##==========================================- Coverage   63.87%   63.67%   -0.21%==========================================  Files         197      197                Lines       11524    11537      +13       Branches       85       85              ==========================================- Hits         7361     7346      -15- Misses       3389     3411      +22- Partials      774      780       +6

Flag	Coverage Δ
unittest-go-	`62.72% <44.44%> (-0.20%)`	⬇️
unittest-go-macos-latest	`58.43% <44.44%> (-0.14%)`	⬇️
unittest-go-ubuntu-latest	`61.31% <44.44%> (-0.14%)`	⬇️
unittest-go-windows-2022	`57.65% <44.44%> (-0.04%)`	⬇️
unittest-js	`63.32% <ø> (ø)`

Impacted Files	Coverage Δ
provisioner/terraform/provision.go	`72.29% <0.00%> (-1.37%)`	⬇️
provisioner/terraform/serve.go	`50.00% <25.00%> (ø)`
cli/start.go	`64.17% <100.00%> (+0.37%)`	⬆️
provisionersdk/transport.go	`74.46% <0.00%> (-6.39%)`	⬇️
provisioner/echo/serve.go	`54.40% <0.00%> (-2.40%)`	⬇️
peer/conn.go	`76.90% <0.00%> (-2.29%)`	⬇️
coderd/provisionerdaemons.go	`62.75% <0.00%> (-1.01%)`	⬇️
provisionerd/provisionerd.go	`80.76% <0.00%> (-0.45%)`	⬇️
peerbroker/listen.go	`87.28% <0.00%> (+3.38%)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatea502a5f...04d9fe3. Read thecomment docs.