Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add trivy vulnerability scanning#5729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 10 commits intomainfromdean/trivy
Jan 16, 2023
Merged

chore: add trivy vulnerability scanning#5729

deansheather merged 10 commits intomainfromdean/trivy
Jan 16, 2023

Conversation

@deansheather
Copy link
Member

  • Rename thecodeql workflow tosecurity
  • Adds trivy vulnerability scanning for the linux_amd64 Docker image

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor comments but looks good 👍🏻.

set -euo pipefail
image_job="build/coder_$(./scripts/version.sh)_linux_amd64.tag"
make -j "$image_job"
echo "image=$(cat "$image_job")" >> $GITHUB_OUTPUT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is one of those "useless use of cat" 😄, consider an alternative:

Suggested change
echo "image=$(cat"$image_job")" >> $GITHUB_OUTPUT
echo "image=$(<"$image_job")" >> $GITHUB_OUTPUT

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like cat :(

mafredri reacted with laugh emoji
@deansheatherdeansheather merged commitb55cb0c intomainJan 16, 2023
@deansheatherdeansheather deleted the dean/trivy branchJanuary 16, 2023 17:43
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredriAwaiting requested review from mafredri

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deansheather@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp