- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: move winget publish into release pipeline#5728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mafredri left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM! 👍🏻
| # we do it again to be safe. | ||
| $version = "${{ needs.release.outputs.version }}".Trim('v') | ||
| $release_assets = gh release view --repo coder/coder "v${version}" --json assets | ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pro tip:gh builtinjq is pretty neat in these situations:
gh release view --repo coder/coder v0.14.2 --json assets --jq'.assets[] | select(.name | test("_windows_amd64_installer.exe$")) | .url'TBH the pwsh script is pretty neat too.
matifali commentedJan 16, 2023
This is cleaner and looks good to me. |
The current winget publish workflow is separate to the release which results in a lot of Tomfoolery when trying to get the version of the last release. This moves the winget publish step to a second job in the release workflow that depends on the release job, using an output from the release job to get the version.
cc:@matifali