Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test: Fix flaky TestServer/Logging/{Multiple,Stackdriver}#5727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 8 commits intomainfrommafredri/test-fix-flaky-log-test
Jan 17, 2023

Conversation

mafredri
Copy link
Member

Saw this flaking on dogfood instance due to Terraform being downloaded and adding a good amount of time (15+ seconds) to startup.

In lieu of disabling terraform download, this should help alleviate such pains.

johnstcn reacted with heart emoji
@mafredrimafredri requested a review frommtojekJanuary 16, 2023 14:47
@mafredrimafredri self-assigned thisJan 16, 2023
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@mafredrimafredri changed the titletest: Fix flaky TestServer/Logging/Multipletest: Fix flaky TestServer/Logging/{Multiple,Stackdriver}Jan 16, 2023
@mafredri
Copy link
MemberAuthor

mafredri commentedJan 17, 2023•
edited
Loading

Ran into temp dir cleanup errors on Windows, at first I tried to fix the wrong issue. Turned out it was a test bug creating and opening files without closing them.

So I introduced two newtestutil functionsTempFile (string) andCreateTemp (likeos.CreateTemp with cleanup) and cleaned up the tests.

@mafredrimafredri merged commitdb78770 intomainJan 17, 2023
@mafredrimafredri deleted the mafredri/test-fix-flaky-log-test branchJanuary 17, 2023 12:14
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@kylecarbskylecarbskylecarbs approved these changes

@mtojekmtojekmtojek approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@mafredri@johnstcn@kylecarbs@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp