Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: Drop unused Experimental flag from api options#5715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Emyrk wants to merge2 commits intomainfromstevenmasley/pass_through_experimental

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedJan 13, 2023•
edited
Loading

Currently theexperimental flag is only set on Enterprise routes viaupdateEntitlements.

In the free version,Experimental is on the api config and never set.

Dropping the unused boolean.

johnstcn reacted with eyes emoji
@EmyrkEmyrk requested a review fromkylecarbsJanuary 13, 2023 19:01
@kylecarbs
Copy link
Member

Hmm, why add this if it's unused? Feels odd.

@Emyrk
Copy link
MemberAuthor

Good point. We return the entitlements in the enterprise route for the UI to consume. I just noticed this when trying to implement a backend experimental feature. I'll just drop it for now.

@EmyrkEmyrk changed the titlechore: Pass through experimental configchore: Drop unused Experimental flag from api optionsJan 13, 2023
@johnstcn
Copy link
Member

Would it instead make more sense to refactor theexperimental flag frombool to[]string so that multiple experimental options can be enabled or disabled independently?

@Emyrk
Copy link
MemberAuthor

@johnstcn It would be nice to support that kind of behavior. This PR just drops the unused flag so no one tries to use it and realizes it does nothing.

A future PR can re-add this functionality in a way that works.

@EmyrkEmyrk closed thisJan 18, 2023
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 18, 2023
@EmyrkEmyrk deleted the stevenmasley/pass_through_experimental branchFebruary 3, 2023 19:00
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Emyrk@kylecarbs@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp