Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add basic support for rich parameters to coderd and provisionerd#5710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 21 commits intocoder:mainfrommtojek:5574-new-parameter-data-source
Jan 17, 2023

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedJan 13, 2023•
edited
Loading

Related:#5574

This PR extracts basic support for rich parameters from#4311. So far, the feature should be accessible via direct interaction with API.
Both parameters, old and rich, should be working, but rich ones aren't exposed to the end user.

Follow-ups:
#5574 (comment)

@mtojekmtojek self-assigned thisJan 13, 2023
@mtojekmtojekforce-pushed the5574-new-parameter-data-source branch from774b80c tof228b34CompareJanuary 16, 2023 15:33
@mtojekmtojek changed the titlefeat: Support rich parameters for templatesfeat: Add basic support for rich parameters to coderd and provisionerdJan 16, 2023
@mtojekmtojek mentioned this pull requestJan 16, 2023
@mtojekmtojek marked this pull request as ready for reviewJanuary 16, 2023 17:31
@mtojekmtojek requested a review froma team as acode ownerJanuary 16, 2023 17:31
@mtojekmtojek requested review frompresleyp and removed request fora teamJanuary 16, 2023 17:31
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Rich parameters is a nice name that doesn't make it super weird to interface with the API.

@mtojekmtojek merged commit6ebadab intocoder:mainJan 17, 2023
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 17, 2023
@bpmctbpmct added this to theRich Parameters GA milestoneFeb 28, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@presleyppresleypAwaiting requested review from presleyppresleyp was automatically assigned from coder/ts

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
@mtojek@kylecarbs@bpmct
[8]ページ先頭
©2009-2025 Movatter.jp