Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: clarify access URL in install flow#5626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bpmct merged 5 commits intomainfrominstall-flow-fixes
Jan 18, 2023
Merged

Conversation

bpmct
Copy link
Member

Partiallyresolves#5564

@bpmctbpmct marked this pull request as ready for reviewJanuary 9, 2023 15:03
$ coder server
Use Coder:
Default URL: http://127.0.0.1:3000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think the Default URL is:8080

Copy link
MemberAuthor

@bpmctbpmctJan 18, 2023
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

it is for./scripts/develop.sh, but not when you install the binary/package

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@bpmctbpmctenabled auto-merge (squash)January 12, 2023 16:22

```sh
# Listen on port 80
export CODER_HTTP_ADDRESS=0.0.0.0:80
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Here you are using0.0.0.0:80 but in L77 you are using127.0.0.1:3000

This is a confusion.


#String. Address to serve the API and dashboard.
CODER_ADDRESS=127.0.0.1:3000
CODER_HTTP_ADDRESS=127.0.0.1:3000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
CODER_HTTP_ADDRESS=127.0.0.1:3000
CODER_HTTP_ADDRESS=0.0.0.0:3000

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm pretty sure the default is the loopback address, according to the help text.

@bpmctbpmct merged commita040bcc intomainJan 18, 2023
@bpmctbpmct deleted the install-flow-fixes branchJanuary 18, 2023 23:23
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 18, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali requested changes

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

+1 more reviewer

@ghuntleyghuntleyghuntley left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing steps after installing via script
4 participants
@bpmct@ghuntley@BrunoQuaresma@matifali

[8]ページ先頭

©2009-2025 Movatter.jp