NotificationsYou must be signed in to change notification settings
Fork929
Star10.1k

feat(dogfood): install nix package manager#5308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mafredri merged 19 commits intomainfromghuntley-patch-2

Jan 26, 2023

Merged

feat(dogfood): install nix package manager#5308

mafredri merged 19 commits intomainfromghuntley-patch-2

Jan 26, 2023

Conversation

Copy link

Contributor

ghuntley commentedDec 6, 2022•
edited
Loading

Internaldiscussion thread.

ghuntley commented

Dec 6, 2022

View reviewed changes

dogfood/Dockerfile OutdatedShow resolvedHide resolved

mtojek self-requested a review

December 6, 2022 13:21

mtojek reviewed

Dec 6, 2022

View reviewed changes

Copy link

Member

mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you please share a bit more context about this change and fix the link in the description?

Copy link

ContributorAuthor

ghuntley commentedDec 6, 2022

Could you please share a bit more context about this change and fix the link in the description?

Apologies - I linked to the wrong link. See conversation at#devrandom. I use nix personally and not having access to the nix package manager is causing self-papercuts. Settingsandbox = false is key to enable installation.

deansheather reviewed

Dec 6, 2022

View reviewed changes

dogfood/Dockerfile OutdatedShow resolvedHide resolved

mafredri reviewed

Dec 8, 2022

View reviewed changes

dogfood/Dockerfile OutdatedShow resolvedHide resolved

ghuntley commented

Dec 8, 2022

View reviewed changes

dogfood/Dockerfile OutdatedShow resolvedHide resolved

ghuntley force-pushed theghuntley-patch-2 branch fromca4652e to9402c6fCompare

December 12, 2022 03:30

mtojek self-requested a review

December 12, 2022 09:50

mtojek approved these changes

Dec 12, 2022

View reviewed changes

Copy link

Member

mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks for addressing the comments! Feel free to merge if other approvers are 👍 .

mafredri reviewed

Dec 12, 2022

View reviewed changes

dogfood/main.tf OutdatedShow resolvedHide resolved

dogfood/Dockerfile OutdatedShow resolvedHide resolved

ghuntley force-pushed theghuntley-patch-2 branch from4e3e64c to38eea8eCompare

December 12, 2022 18:55

Copy link

github-actionsbot commentedDec 20, 2022

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

github-actionsbot added the staleThis issue is like stale bread. label

Dec 20, 2022

ghuntleyand others added12 commits

December 22, 2022 07:04

feat(dogfood): install nix package manager

78e395e

Update dogfood/Dockerfile

f166695

enable unfree and source in bashprofile

ee4f7b6

style/linting adjustments.

22b2535

Co-authored-by: Dean Sheather <dean@deansheather.com>

add comments

8ac9021

ensure coder user can write to /nix

7984ed7

chown coder:coder /nix

41d1aef

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>

add further comments

25b1ac3

🎶https://www.youtube.com/watch?v=oRdxUFDoQe0

0872948

pin it, just pin it

hopefully the final review iteration, thanks for your help!

a516413

arg not export

68402a9

Update dogfood/Dockerfile

fb1eac8

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>

ghuntley force-pushed theghuntley-patch-2 branch from7b5e174 tofb1eac8Compare

December 22, 2022 07:08

ghuntley commented

Dec 22, 2022

View reviewed changes

dogfood/main.tfShow resolvedHide resolved

Copy link

ContributorAuthor

ghuntley commentedDec 22, 2022

Thanks@mafredri and@mtojek for your eyeballs and guidance here.

line now exists in main.tf

ec10dc1

ghuntley force-pushed theghuntley-patch-2 branch froma37bc93 toec10dc1Compare

December 22, 2022 07:11

remove whitespace

fd882b2

mafredri approved these changes

Dec 22, 2022

View reviewed changes

Copy link

Member

mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work, looking pretty clean! 👍🏻

dogfood/main.tf Outdated

Comment on lines 61 to 62

		echo '. /home/coder/.nix-profile/etc/profile.d/nix.sh' >> /home/coder/.bashrc
		bash /opt/nix/install --no-daemon

Copy link

Member

mafredriDec 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Didn't test this, but imagine it should be a bit more portable and avoid adding the entry every startup.

Suggested change

	echo './home/coder/.nix-profile/etc/profile.d/nix.sh'>>/home/coder/.bashrc
	bash/opt/nix/install--no-daemon
	bash/opt/nix/install--no-daemon
	if! grep-q '. ~/.nix-profile/etc/profile.d/nix.sh' ~/.bashrc; then
	echo '. ~/.nix-profile/etc/profile.d/nix.sh'>> ~/.bashrc
	fi

Ultimately, we might want to add this logic into/etc/profile.d/nix.sh and/etc/zsh/zprofile (via Dockerfile) so that it's available in all shells. But that can be done in a separate PR.

github-actionsbot removed the staleThis issue is like stale bread. label

Dec 23, 2022

Copy link

github-actionsbot commentedJan 6, 2023

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

github-actionsbot added the staleThis issue is like stale bread. label

Jan 6, 2023

kylecarbsand others added4 commits

January 17, 2023 14:49

Merge branch 'main' into ghuntley-patch-2

ae0f24b

Apply@mafredri's suggestion

4160ad4

Fix user

9417529

Match indent

d89f634

mafredri removed the staleThis issue is like stale bread. label

Jan 18, 2023

Copy link

github-actionsbot commentedJan 26, 2023

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.