- Notifications
You must be signed in to change notification settings - Fork928
fix: Syntax highlighting with long lines and untar content with emojis#5098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -38,10 +36,9 @@ const setup = async () => { | |||
| describe("TemplateVersionPage", () => { | |||
| beforeEach(setup) | |||
| it("shows the tf and md files only", () => { | |||
| it("shows files", () => { | |||
| expect(screen.queryByText(TERRAFORM_FILENAME)).toBeInTheDocument() | |||
| expect(screen.queryByText(README_FILENAME)).toBeInTheDocument() | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why did we end up changing this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because now, the filtering happens inside of the "parsing" function. I made it to not have to parse 100 files to only get 2 of them after.
Before:
Now:
Unfortunately there is a bug with "wrapping long lines" with the
react-syntax-highlither.react-syntax-highlighter/react-syntax-highlighter#483