NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

fix: Misc improvements to`scripts/develop.sh`#4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mafredri merged 4 commits intomainfrommafredri/develop-script-improvements

Nov 10, 2022

Merged

fix: Misc improvements to`scripts/develop.sh`#4995

mafredri merged 4 commits intomainfrommafredri/develop-script-improvements

Nov 10, 2022

Conversation

Copy link

Member

mafredri commentedNov 10, 2022•
edited
Loading

Use new/healthz endpoint for checking API liveness
Improved credential handling/retrying in failure scenarios
Separate site (vite) logs with prefix and date, additionally this
method also disables thevite clearing of the screen
Show all interfaces coder API is listening on (due to0.0.0.0)

Edit:

Improved shutdown procedure / interrupt handling (ac5d221)

mafredri requested a review froma team

November 10, 2022 11:40

mafredri force-pushed themafredri/develop-script-improvements branch from1256ec4 toec48b37Compare

November 10, 2022 11:41

fix: Misc improvements toscripts/develop.sh

5fd8657

* Use new `/healthz` endpoint for checking API liveness* Improved credential handling/retrying in failure scenarios* Separate site (`vite`) logs with prefix and date, additionally this  method also disables the `vite` clearing of the screen* Show all interfaces coder API is listening on (due to `0.0.0.0`)

mafredri force-pushed themafredri/develop-script-improvements branch fromec48b37 to5fd8657Compare

November 10, 2022 11:46

mafredri marked this pull request as ready for review

November 10, 2022 11:46

mtojek reviewed

Nov 10, 2022

View reviewed changes

scripts/develop.shShow resolvedHide resolved

scripts/develop.sh OutdatedShow resolvedHide resolved

Amen PR comment, name the padding

3e438e7

mafredri force-pushed themafredri/develop-script-improvements branch from1c895d3 to3e438e7Compare

November 10, 2022 12:32

Amen PR comment, use curl instead of timeout

7f1f744

mafredri force-pushed themafredri/develop-script-improvements branch fromde51030 to7f1f744Compare

November 10, 2022 12:50

feat: Better interrupt handling

ac5d221

Copy link

MemberAuthor

mafredri commentedNov 10, 2022

Ok, made one pretty big additional change inac5d221.

Interrupts, failures and cleanup should be handled better now. I often ran into issues with PostgreSQL or node (vite) still running after the script has exited.