Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: ignore .envrc#4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 1 commit intocoder:mainfrommtojek:fix-envrc
Nov 10, 2022
Merged

chore: ignore .envrc#4994

mtojek merged 1 commit intocoder:mainfrommtojek:fix-envrc
Nov 10, 2022

Conversation

mtojek
Copy link
Member

OurCONTRIBUTING page recommends setting the .envrc file to automatically enable the nix-shell.

This PR adds the.envrc to the.gitignore. I assume that not every developer usesnix-shell, but can usedirenv, and in this case, the.envrc will be problematic.

ghuntley and mafredri reacted with heart emojighuntley reacted with eyes emoji
@mtojekmtojek requested a review froma teamNovember 10, 2022 09:59
@mtojekmtojek self-assigned thisNov 10, 2022
@ghuntley
Copy link
Contributor

Over at#3790 (comment) discusses gitignoring it and the outcome was not to do it.

@mtojek
Copy link
MemberAuthor

Thanks for bringing it up! I see that the following options have been considered:

  1. Tell git to ignore changes to .envrc or to never check out the file (after some research, doesn't seem possible)
  2. Tell direnv to source an alternative file

There is another option, but it isn't straightforward. We could commit the file to the repository, and then update the.gitignore, so that anyone can overwrite it locally and adjust it to their own needs, but won't overwrite the remote. I don't know what's the adoption ofdirenv and how many devs have their own custom.envrc (as@mafredri).

If we don't agree on marking.envrc as ignored, I can update our CONTRIBUTING docs with instructions to add the file to global .gitignore. I'm afraid that this file will start leaking to community pull-requests as people tend togit add --all.

@mafredri
Copy link
Member

Over at#3790 (comment) discusses gitignoring it and the outcome was not to do it.

@ghuntley I was probably unclear on that point. Adding to.gitignore is fine (and good even IMO). It was simply the case that having.envrc committed to the repoand added to.gitignore produces no additional benefit for the issue.

I probably would've raised a PR like this myself but.envrc is part of my personal.gitignore so I didn't notice. 😅

mtojek reacted with thumbs up emoji

@mtojek
Copy link
MemberAuthor

Ok, glad to see that we've an agreement, so I will merge it :)

@mtojekmtojek merged commitd64c73d intocoder:mainNov 10, 2022
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@ghuntleyghuntleyAwaiting requested review from ghuntley

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mtojek@ghuntley@mafredri

[8]ページ先頭

©2009-2025 Movatter.jp