- Notifications
You must be signed in to change notification settings - Fork925
feat: pprof for coder agent is always on#4951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is port 6060 used frequently for development by any language? I'd hate to modify someone's workflow if they adopt Coder. I also believe our port forward dialog will pick this up and display it in the UI, which we should disable. It might be worth considering only doing this behavior on Windows, but that's also kinda jank. |
mtojek commentedNov 8, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Looking at thespeedguide stats, it seems to be mostly related to pprof debugging, so it should be safe.
I think that it's worth keeping the consistent behavior, otherwise, we may confuse people working on different OS platforms. I'm pretty sure that users will survive with 1 more reserved port.
I understand that we wouldn't like to expose the 6060 in the port-forward mode, am I correct? I'm wondering if it isn't a feature to allow for accessing it, even for customer debugging purposes (heap dump?) |
Fixes:#2081
This PR enables the pprof endpoint for the coder agent by default. It may result in port conflicts if there is another application listening on that port (
127.0.0.1:6060
).