Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: pprof for coder agent is always on#4951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 1 commit intocoder:mainfrommtojek:2081-pprof-endpoint
Nov 8, 2022

Conversation

mtojek
Copy link
Member

Fixes:#2081

This PR enables the pprof endpoint for the coder agent by default. It may result in port conflicts if there is another application listening on that port (127.0.0.1:6060).

@mtojekmtojek self-assigned thisNov 8, 2022
@mtojekmtojek changed the titlefeat: pprof is always onfeat: pprof for coder agent is always onNov 8, 2022
@mtojekmtojek marked this pull request as ready for reviewNovember 8, 2022 13:22
@mtojekmtojek requested a review froma teamNovember 8, 2022 13:22
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

image

😍

mtojek reacted with hooray emoji
@mtojekmtojek merged commitbf4a6fb intocoder:mainNov 8, 2022
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 8, 2022
@kylecarbs
Copy link
Member

Is port 6060 used frequently for development by any language? I'd hate to modify someone's workflow if they adopt Coder.

I also believe our port forward dialog will pick this up and display it in the UI, which we should disable. It might be worth considering only doing this behavior on Windows, but that's also kinda jank.

@mtojek
Copy link
MemberAuthor

mtojek commentedNov 8, 2022
edited
Loading

Is port 6060 used frequently for development by any language? I'd hate to modify someone's workflow if they adopt Coder.

Looking at thespeedguide stats, it seems to be mostly related to pprof debugging, so it should be safe.

It might be worth considering only doing this behavior on Windows, but that's also kinda jank.

I think that it's worth keeping the consistent behavior, otherwise, we may confuse people working on different OS platforms. I'm pretty sure that users will survive with 1 more reserved port.

I also believe our port forward dialog will pick this up and display it in the UI, which we should disable.

I understand that we wouldn't like to expose the 6060 in the port-forward mode, am I correct? I'm wondering if it isn't a feature to allow for accessing it, even for customer debugging purposes (heap dump?)

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for enabling pprof endpoints incoder agent on Windows during runtime
3 participants
@mtojek@kylecarbs@mafredri

[8]ページ先頭

©2009-2025 Movatter.jp