- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: make trace provider in loadtest, add tracing to sdk#4939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| ctx,span:=tracing.StartSpan(ctx) | ||
| deferspan.End() | ||
| conn,err:=c.DialContextTCP(ctx,netip.AddrPortFrom(TailnetIP,uint16(TailnetReconnectingPTYPort))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Might be nice to capture the errors in the span too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There are a lot of errors across the codebase we would have to catch, so it's kinda weird to only do it here. It'd be nice if we could hook into all returned error values in Golang but I don't think that's possible without writing and enforcing a wrapper for errors instead of xerrors.Errorf
deansheather commentedNov 8, 2022
Propagation works properly now. |
coder loadtestusing the given configuration flagscodersdk.(*Client).Request(using parent function name) and select other methods in codersdk*Clientthrough an option) and coderd using the standardizedtraceparentheaderUntested whether the tracing propagation works, I'll need to setup a test env for it