- Notifications
You must be signed in to change notification settings - Fork928
feat: Add external provisioner daemons#4935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Kira-Pilot approved these changesNov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FE ✅
1436324 to29f6f49Comparecoadler approved these changesNov 16, 2022
Uh oh!
There was an error while loading.Please reload this page.
coderd/database/migrations/000077_provisioner_daemon_tags.down.sql OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
f02e82d to2fa16e4Compare2fa16e4 toea94e1bCompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This adds the concept of tags to provisioner daemons.
When creating a template or pushing a new version,
--provisioner-tagis now a command-line option. This allows you to target provisioners with the matching set of tags.coder provisionerd start --tag key=valuelaunches a new provisioner daemon.scope=useris aspecial tag that will auto-insert theowner=<user-id>tag when the user initializes build operations for their resources. This solves#909 by allowing users to run a daemon, and template admins can target them.This feature lacks polish right now (notably, the UI will show a "Pending" state if a daemon isn't matching the specified tags), but that seems fine while we initially test. This doesn't make any irreversible changes, so it should be good to merge.