Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: Remove workspace schedule banner#4932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 1 commit intomainfrombq/remove-shutdown-warning
Nov 8, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Close#4919

It's unnecessary now that we have activity-based extension.

@BrunoQuaresmaBrunoQuaresma requested a review froma team as acode ownerNovember 7, 2022 16:51
@BrunoQuaresmaBrunoQuaresma self-assigned thisNov 7, 2022
@BrunoQuaresmaBrunoQuaresma requested review frompresleyp and removed request fora teamNovember 7, 2022 16:51
@BrunoQuaresma
Copy link
CollaboratorAuthor

@presleyp I see we have aworkspaceScheduleBannerXService but it does more than control the banner. Is it ok if we rename it toworkspaceScheduleXService instead?

@presleyp
Copy link
Contributor

@presleyp I see we have aworkspaceScheduleBannerXService but it does more than control the banner. Is it ok if we rename it toworkspaceScheduleXService instead?

Yes, thanks!

@BrunoQuaresma
Copy link
CollaboratorAuthor

@presleyp I see we already have aworkspaceScheduleXService. I'm merging this for now and I will investigate that after.

@BrunoQuaresmaBrunoQuaresma merged commit2af698c intomainNov 8, 2022
@BrunoQuaresmaBrunoQuaresma deleted the bq/remove-shutdown-warning branchNovember 8, 2022 13:05
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 8, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@presleyppresleypAwaiting requested review from presleyppresleyp was automatically assigned from coder/ts

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove workspace about to shut down system notification
3 participants
@BrunoQuaresma@presleyp@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp