Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: windows winget package auto update on every release#4761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 7 commits intocoder:mainfrommatifali:winget-release
Nov 14, 2022
Merged

chore: windows winget package auto update on every release#4761

deansheather merged 7 commits intocoder:mainfrommatifali:winget-release
Nov 14, 2022

Conversation

matifali
Copy link
Member

@matifalimatifali commentedOct 26, 2022
edited by deansheather
Loading

Addedwinget publish action on release.
Linked to#3714
@deansheather

bpmct and deansheather reacted with hooray emoji
Added `winget` update action on release
@matifali
Copy link
MemberAuthor

Not sure how to test it. Will it submit the package in my name or the coder

@deansheatherdeansheather self-requested a reviewOctober 26, 2022 11:43
A GitHub Personal Access token is required to submit packages to winget community repo.https://github.com/microsoft/winget-create/blob/main/doc/token.mdPlease create a token as shown here and store it as a secret in `GITHUB_PAT`
@matifalimatifali marked this pull request as ready for reviewOctober 27, 2022 10:34
@matifali
Copy link
MemberAuthor

To push an update, we first need to create a package for the first time that is interactive and manual.
I am not sure if it has to be created using Coder Inc. GitHub or if I can do it from my account.
Meanwhile, I have created a PR here also,
microsoft/winget-pkgs#86416
and tried to fill in all the required metadata from coder.com/

@matifali
Copy link
MemberAuthor

matifali commentedOct 27, 2022
edited
Loading

Also,
A GitHub Personal Access token is required to submit packages to winget community repo.

https://github.com/microsoft/winget-create/blob/main/doc/token.md

Please create a token as shown here and store it as a secret inGITHUB_PAT

Or maybe the existingGITHUB_TOKEN be used. It's a test.
@deansheather

@matifali
Copy link
MemberAuthor

matifali commentedOct 28, 2022
edited
Loading

To push an update, we first need to create a package for the first time that is interactive and manual.
I am unsure if it has to be created using Coder Inc. GitHub or if I can do it from my account.
Meanwhile, I have created a PR here also,
microsoft/winget-pkgs#86416
and tried to fill in all the required metadata from coder.com/

My PR was closed as a duplicate ofmicrosoft/winget-pkgs#86238, I did not check that you have already submitted a PR.

@deansheather
Copy link
Member

I'll do a review pass of this PR on Monday and get it merged for you. We'll sort out the bounty payout post-merge cc@ghuntley

@deansheather
Copy link
Member

I updated your PR to use GH CLI instead of pinging the API directly (to avoid potential ratelimits), as well as updated it to comment on the PR pinging me so microsoft maintainers can get in contact with me if something's wrong.

I also discovered that the file version I was inserting into the installer binary was incorrect so I fixed that as well.

Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM but I contributed so I'll get Colin to review it

@matifali
Copy link
MemberAuthor

matifali commentedNov 1, 2022
edited
Loading

I updated your PR to use GH CLI instead of pinging the API directly (to avoid potential ratelimits), as well as updated it to comment on the PR pinging me so microsoft maintainers can get in contact with me if something's wrong.

I also discovered that the file version I was inserting into the installer binary was incorrect so I fixed that as well.

Yes, it looks like a better approach. Yes, the installer version had the 4th section as the release date.
Also, to test this in production it should be merged before the next release.

@deansheatherdeansheatherenabled auto-merge (squash)November 2, 2022 11:58
@ghuntley
Copy link
Contributor

ghuntley commentedNov 8, 2022
edited
Loading

Thanks for sending in the pull-request@matifali I'm going to have a look/review after lunch. A quick note to say haven't forgotten!

matifali reacted with thumbs up emoji

@matifalimatifali changed the titleCreate submit-windows-packages.ymlchore: windows winget package auto update on every releaseNov 8, 2022
@deansheatherdeansheather merged commit990be63 intocoder:mainNov 14, 2022
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 14, 2022
@matifalimatifali deleted the winget-release branchNovember 14, 2022 13:34
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather left review comments

@coadlercoadlercoadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@matifali@deansheather@ghuntley@coadler

[8]ページ先頭

©2009-2025 Movatter.jp