Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add windows amd64 installer#4719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 7 commits intomainfromdean/installer
Oct 25, 2022
Merged

feat: add windows amd64 installer#4719

deansheather merged 7 commits intomainfromdean/installer
Oct 25, 2022

Conversation

deansheather
Copy link
Member

@deansheatherdeansheather commentedOct 24, 2022•
edited
Loading

Adds a Windows amd64 installer (built on Linux) usingmakensis. NSIS is an alternative to MSI which can easily be built on platforms other than Windows, and is used by well-known apps such as VLC and VirtualBox.

Drops the following files inC:\Program Files\Coder:

  • bin/coder.exe
  • uninstaller.exe
  • license.txt

Optionally addsbin to PATH. Registers Coder as an app in Windows settings so users can easily uninstall it.

coder_0.10.2-devel+bf3224e3_windows_amd64_installer_NnWUVJKzWY.mp4

@kylecarbs
Copy link
Member

Does the user need to sign out and sign in for thePATH to change?

@deansheather
Copy link
MemberAuthor

Does the user need to sign out and sign in for the PATH to change?

@kylecarbs It's the easiest way to get PATH updates to apply without having to run crazy commands to force refresh the PATH variable AFAIK

kylecarbs reacted with thumbs up emoji

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is awesome!

Could you adjust this in the README?https://github.com/coder/coder#getting-started

Add under:

The easiest way to install Coder is to use our [install script](https://github.com/coder/coder/blob/main/install.sh) for Linux and macOS. For Windows, use our [installer](<link to latest release installer bin here>).

@deansheather
Copy link
MemberAuthor

@kylecarbs there's no permalink for the installer, so I put the following in the README instead:

For Windows, use the latest `..._installer.exe` file from GitHub Releases.
kylecarbs reacted with thumbs up emoji

@kylecarbs
Copy link
Member

@deansheather hmm, that makes sense to me. link to the latest release too!

Thoughts on this?https://stackoverflow.com/questions/6979741/setting-environment-variables-requires-reboot-on-64-bit

btw this isn't blocking, just cool if it's easy to do

@kylecarbs
Copy link
Member

@deansheather can we include the version somewhere in the installer UI? Might be helpful for folks

@matifali
Copy link
Member

matifali commentedOct 25, 2022•
edited
Loading

Also, it will allow publishing onwinget as currently, it does not allow publishing a portable app from inside a zip.
#3729

@deansheather
Copy link
MemberAuthor

deansheather commentedOct 25, 2022•
edited
Loading

yep@matifali this is a follow up I'd like to do after merge :D

matifali and kylecarbs reacted with thumbs up emoji

@deansheatherdeansheather merged commit067362c intomainOct 25, 2022
@deansheatherdeansheather deleted the dean/installer branchOctober 25, 2022 14:19
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 25, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@zouncezouncezounce approved these changes

@sreyasreyaAwaiting requested review from sreya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@deansheather@kylecarbs@matifali@zounce
[8]ページ先頭
©2009-2025 Movatter.jp