- Notifications
You must be signed in to change notification settings - Fork928
feat(setup): organization is not longer needed#4707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for taking a look at this one! It seems to me that the API is asking we send down an organization. You can see where we send down data of this typeinapi.ts.
Not sure what needs to be altered server-side here, but we'll need to regenerate those types after a change is made so that lint stops complaining.
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
I went back in there and removed all backend references. Would appreciate a second set of eyes on this one as first time making backend+frontend changes in the project. |
| {...getFieldHelpers("organization")} | ||
| onChange={onChangeTrimmed(form)} | ||
| autoFocus | ||
| fullWidth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It might be nice to giveautoFocus to the next field so that users can start typing without clicking into the form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FE ✅
Uh oh!
There was an error while loading.Please reload this page.
Resolves (in theory)#4697