- Notifications
You must be signed in to change notification settings - Fork928
Add Chocolatey publishing#4706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
github-actionsbot commentedOct 23, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
df56dee to9cd2f31Compare| set -e | ||
| function choco { | ||
| mono /opt/chocolatey/choco.exe "$@" --allow-unofficial --nocolor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Instead of running this in mono in a docker container, could this just run on a windows runner instead? A similar PR for winget had the idea of just running this publish step post-publish by using
on:release:types:[published]
Then we could just useruns-on: windows-latest, install chocolatey and use it the normal way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Probably, I've initially reused work from other project I maintain where it just runs as GitHub action as container
9cd2f31 tocfda410CompareSince exe installer has been added, I've removed MSI building but let me know if you would be still interested in it |
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
Thanks for sending in the pull-request@panekj I'm going to have a look/review after lunch. A quick note to say haven't forgotten! |
| && chmod +x build.sh zip.sh \ | ||
| && ./build.sh -v \ | ||
| && mv ./code_drop/chocolatey/console /opt/chocolatey \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@ghuntley these steps shouldn't be necessary. Manually building Chocolatey is no longer required, as we ship a Docker Image ready to be used:https://hub.docker.com/u/chocolatey
Uh oh!
There was an error while loading.Please reload this page.
| set -e | ||
| function choco { | ||
| mono /opt/chocolatey/choco.exe "$@" --allow-unofficial --nocolor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If you switch to using the official Docker image, usage of--allow-unofficial will not be required.
Co-authored-by: Gary Ewan Park <gep13@gep13.co.uk>
9018d8f to99e8656CompareNeeds to be moved to |
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
Uh oh!
There was an error while loading.Please reload this page.
Fixes#3714
You need to set secret
CHOCOLATE_KEYwith API key from Chocolatey