Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Add emoji picker to group settings#4685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromgroupmoji
Oct 21, 2022
Merged

feat: Add emoji picker to group settings#4685

kylecarbs merged 1 commit intomainfromgroupmoji
Oct 21, 2022

Conversation

kylecarbs
Copy link
Member

Fixes#4413.

@kylecarbskylecarbs requested a review frombpmctOctober 21, 2022 17:13
@kylecarbskylecarbs requested a review froma team as acode ownerOctober 21, 2022 17:13
@kylecarbskylecarbs self-assigned thisOct 21, 2022
@kylecarbskylecarbs requested review fromKira-Pilot and removed request fora teamOctober 21, 2022 17:13
"--rgb-background": theme.palette.background.paper,
"--rgb-input": colors.gray[17],
"--rgb-color": colors.gray[4],
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we want to add thissite/src/theme/overrides.ts? I feel like I might not look for it here.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I just copied this from the template settings one, but I assume we'll abstract this (maybe once it's used once more?).

Copy link
Member

@Kira-PilotKira-PilotOct 21, 2022
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I could be wrong, but I thought the@global key meant any classes defined within would be defined globally. So, if this is already declared in template settings, I'm surprised we need it here, too.

I'm suggesting we move it tooverrides because we have a bunch of other globals there, and it's nice to have them colocated. But not a blocker.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I believe the@global will go away when the component is unmounted, so it won't actually apply globally to all pages, just to the global scope on this page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ohhh, interesting; thanks for explaining. Alrighty, let's keep it!

Copy link
Member

@Kira-PilotKira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice!

@kylecarbskylecarbsenabled auto-merge (squash)October 21, 2022 19:36
@kylecarbskylecarbs merged commit0d27b59 intomainOct 21, 2022
@kylecarbskylecarbs deleted the groupmoji branchOctober 21, 2022 19:42
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 21, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

@bpmctbpmctbpmct approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groups: add icon/emoji to groups
3 participants
@kylecarbs@Kira-Pilot@bpmct

[8]ページ先頭

©2009-2025 Movatter.jp