- Notifications
You must be signed in to change notification settings - Fork928
feat: support wildcard apps over tunnel#4602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| } | ||
| // Suffixed wildcard access URL. | ||
| dflags.WildcardAccessURL.Value = fmt.Sprintf("*--%s", u.Hostname()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't this just be one hypen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
acutaly looks like ti deosnt matter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yeah it doesn't matter on the server side how many hyphens you use, but I used two here so it matches the two hyphens between each app component
I'm going to merge this even though I'm still making improvements on the tunnel server side to allow for shorter hostnames. Right now, since the tunnel hostname takes up 32 characters users only have 22 characters (excluding the 8 hyphens) for their app name, agent name, workspace name and username. I'm hoping to reduce the hostname size on tunnels from 32 characters to 13 characters, and looking into whether we can remove the agent name from the URL for named apps if we make app slugs unique per workspace. |
Uh oh!
There was an error while loading.Please reload this page.
Closes#4517
Added wildcard support to the tunnel server incoder/wgtunnel#2.
If
--access-urlis undefined, a persistent tunnel URL will be generated for the server. If--wildcard-access-urlis also not defined, it will set the wildcard access URL to*--$TUNNEL_HOSTi.e.*--abcdef.tunnel.dev. Subdomain-based apps and port-forwarding should work out of the box for tunneled coder deployments.