Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Copy replicas to prevent race#4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromreplicarace
Oct 17, 2022
Merged
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletionenterprise/replicasync/replicasync.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -315,7 +315,14 @@ func (m *Manager) Self() database.Replica {
func (m *Manager) All() []database.Replica {
m.mutex.Lock()
defer m.mutex.Unlock()
return append(m.peers[:], m.self)
replicas := make([]database.Replica, 0, len(m.peers))
for _, replica := range append(m.peers, m.self) {
// When we assign the non-pointer to a
// variable it loses the reference.
replica := replica
replicas = append(replicas, replica)
}
return replicas
}

// Regional returns all replicas in the same region excluding itself.
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp