NotificationsYou must be signed in to change notification settings
Fork926
Star10.1k

fix: Fix template create with sub-folders on Windows#4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mafredri merged 1 commit intomainfrommafredri/fix-template-create-on-windows

Oct 14, 2022

Merged

fix: Fix template create with sub-folders on Windows#4548

mafredri merged 1 commit intomainfrommafredri/fix-template-create-on-windows

Oct 14, 2022

Conversation

Copy link

Member

mafredri commentedOct 14, 2022

On Windows, files in tar archives were stored with Windows
path-separators resulting in them being individual files as opposed to
contained in a folder.

This commit ensures Unix-based paths (slash) are being used inside tar
archives.

Exmple of previous output:

/tmp/provisionerd673501182/images:/tmp/provisionerd673501182/:README.mdimagesimages\base.Dockerfileimages\java.Dockerfileimages\node.Dockerfilemain.tf

Fixes#2815

fix: Fix template create with sub-folders on Windows

25aa0dd

On Windows, files in tar archives were stored with Windowspath-separators resulting in them being individual files as opposed tocontained in a folder.This commit ensures Unix-based paths (slash) are being used inside tararchives.Exmple of previous output:```/tmp/provisionerd673501182/images:/tmp/provisionerd673501182/:README.mdimagesimages\base.Dockerfileimages\java.Dockerfileimages\node.Dockerfilemain.tf```Fixes#2815

mafredri self-assigned this

Oct 14, 2022

mafredri requested a review froma team

October 14, 2022 09:11