Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add auditing for groups#4527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sreya merged 15 commits intomainfromjon/groupaudit
Oct 19, 2022
Merged

feat: add auditing for groups#4527

sreya merged 15 commits intomainfromjon/groupaudit
Oct 19, 2022

Conversation

sreya
Copy link
Collaborator

@sreyasreya commentedOct 13, 2022
edited
Loading

  • Adds auditing for most aspects of template RBAC. Group members will be submitted separately.
  • Cleans up theTemplateACL type by turning it into a driver and integrating it more directly intosqlc.

create group:

image

update group:

image

delete group:

image

update template acl:

image

fixes#4503

@sreyasreya requested a review froma team as acode ownerOctober 19, 2022 00:21
@sreyasreya requested review fromBrunoQuaresma andcoadler and removed request fora teamOctober 19, 2022 00:21
@@ -24,3 +24,22 @@ func (a *Actions) Scan(src interface{}) error {
func (a *Actions) Value() (driver.Value, error) {
return json.Marshal(a)
}

// TemplateACL is a map of ids to permissions.
type TemplateACL map[string][]rbac.Action
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could this be amap[uuid.UUID][]rbac.Action?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

possibly but it involves a lot of code changes, i'll try it out in a separate pr

@sreyasreya merged commit0d1096d intomainOct 19, 2022
@sreyasreya deleted the jon/groupaudit branchOctober 19, 2022 07:00
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 19, 2022
@Kira-Pilot
Copy link
Member

🥳

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@coadlercoadlercoadler approved these changes

@BrunoQuaresmaBrunoQuaresmaAwaiting requested review from BrunoQuaresmaBrunoQuaresma was automatically assigned from coder/ts

@Kira-PilotKira-PilotAwaiting requested review from Kira-Pilot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groups: add audit logging
3 participants
@sreya@Kira-Pilot@coadler

[8]ページ先頭

©2009-2025 Movatter.jp