Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: duplicate workspace update entries#4513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Kira-Pilot merged 6 commits intomainfromworkspace-update-logs-twice/kira-pilot
Oct 14, 2022

Conversation

Kira-Pilot
Copy link
Member

@Kira-PilotKira-Pilot commentedOct 12, 2022•
edited
Loading

resolves#4317

This was happening because we sent down two requests when we updated the workspace schedule form: 1) to/autostart, with an empty payload and 2) to/ttl with our updated auto-off. This was creating two audit logs, one without a diff.

This PR fixes the following

  • cleans up that errant, empty API call on the FE
  • makes sure the BE only creates log entries if there are actually diffs
  • filters out audit logs with 0 diffs on the FE so that users don't see these old, nonsense records

Before
Screen Shot 2022-10-12 at 9 37 32 AM

After:
Screen Shot 2022-10-12 at 9 37 11 AM

@Kira-PilotKira-Pilot requested a review froma team as acode ownerOctober 12, 2022 14:19
@Kira-PilotKira-Pilot requested review fromBrunoQuaresma and removed request fora teamOctober 12, 2022 14:19
@github-actions
Copy link

github-actionsbot commentedOct 12, 2022•
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Kira-Pilot
Copy link
MemberAuthor

I have read the CLA Document and I hereby sign the CLA

@Kira-Pilot
Copy link
MemberAuthor

recheck

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@Kira-PilotKira-Pilot merged commitdd8ebf1 intomainOct 14, 2022
@Kira-PilotKira-Pilot deleted the workspace-update-logs-twice/kira-pilot branchOctober 14, 2022 18:39
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@coadlercoadlerAwaiting requested review from coadler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit: Two entries created for adding a auto-stop time of 1 hour
3 participants
@Kira-Pilot@BrunoQuaresma@coadler
[8]ページ先頭
©2009-2025 Movatter.jp