Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: Add group badge to diff groups from users#4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 2 commits intomainfrombq/add-group-avatar
Oct 11, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Closes#4459

Before:
Screen Shot 2022-10-11 at 10 25 28

After:
Screen Shot 2022-10-11 at 10 25 18

@BrunoQuaresmaBrunoQuaresma self-assigned thisOct 11, 2022
@BrunoQuaresmaBrunoQuaresma requested a review froma team as acode ownerOctober 11, 2022 13:26
@BrunoQuaresmaBrunoQuaresma requested review fromcode-asher andKira-Pilot and removed request fora teamOctober 11, 2022 13:26
height: 14,
},
},
}))(Badge)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What does(Badge) do here? Is that applying the styles forBadge as well?

Copy link
CollaboratorAuthor

@BrunoQuaresmaBrunoQuaresmaOct 11, 2022•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, it is a better way, IMO, to modify component styles. So what it does is extend theBadge component with the new styles.

Kira-Pilot reacted with thumbs up emoji
Copy link
Member

@Kira-PilotKira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cute!

BrunoQuaresma reacted with heart emoji
Co-authored-by: Kira Pilot <kira@coder.com>
@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)October 11, 2022 14:31
@BrunoQuaresmaBrunoQuaresma merged commita64731e intomainOct 11, 2022
@BrunoQuaresmaBrunoQuaresma deleted the bq/add-group-avatar branchOctober 11, 2022 14:39
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

@code-ashercode-asherAwaiting requested review from code-ashercode-asher was automatically assigned from coder/ts

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groups: add visual indicator to distinguish groups from users
2 participants
@BrunoQuaresma@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp