- Notifications
You must be signed in to change notification settings - Fork1k
fix: Fix storybook blockers#443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Unfortunately the |
I would love for us to have Chromatic (Snapshot testing). The only reason it was removed temporarily was because we hadn't set up a proper plan and figured out the best pipeline/usage for it yet. I do see it as above "nice-to-have" in terms of priority for regression prevention. While visual regressions can seem lower risk, they're still a risk that could disrupt somebodies workflow |
codecovbot commentedMar 15, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #443 +/- ##==========================================+ Coverage 68.14% 68.24% +0.10%========================================== Files 159 158 -1 Lines 9226 9224 -2 Branches 73 73 ==========================================+ Hits 6287 6295 +8+ Misses 2317 2310 -7+ Partials 622 619 -3
Continue to review full report at Codecov.
|
Agree 100% with your comments@vapurrmaid - I logged#444 to track investigate bringing Chromatic back. |
Uh oh!
There was an error while loading.Please reload this page.
I was just testing
storybook
out onmain
, and saw some of the components had errors:There were two problems:
<Workspace />
component had new arguments, that don't seem to be validated byyarn storybook:build
react-router-dom
is not available in storybook.After fixing these, all the storybook components work: