Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Fix storybook blockers#443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bryphe-coder merged 1 commit intomainfrombryphe/fix/storybook-build
Mar 15, 2022
Merged

Conversation

bryphe-coder
Copy link
Contributor

@bryphe-coderbryphe-coder commentedMar 15, 2022
edited
Loading

I was just testingstorybook out onmain, and saw some of the components had errors:

image

There were two problems:

  • The<Workspace /> component had new arguments, that don't seem to be validated byyarn storybook:build
  • The top-levelreact-router-dom is not available in storybook.

After fixing these, all the storybook components work:

image

@bryphe-coderbryphe-coder self-assigned thisMar 15, 2022
@bryphe-coder
Copy link
ContributorAuthor

Unfortunately theyarn storybook:build command doesn't seem to catch these errors - I guess it's an argument for bringing back chromatic!

@greyscaled
Copy link
Contributor

Unfortunately theyarn storybook:build command doesn't seem to catch these errors - I guess it's an argument for bringing back chromatic!

I would love for us to have Chromatic (Snapshot testing). The only reason it was removed temporarily was because we hadn't set up a proper plan and figured out the best pipeline/usage for it yet.

I do see it as above "nice-to-have" in terms of priority for regression prevention. While visual regressions can seem lower risk, they're still a risk that could disrupt somebodies workflow

bryphe-coder reacted with thumbs up emoji

@codecov
Copy link

codecovbot commentedMar 15, 2022
edited
Loading

Codecov Report

Merging#443 (54e2cc8) intomain (97399f8) willincrease coverage by0.10%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main     #443      +/-   ##==========================================+ Coverage   68.14%   68.24%   +0.10%==========================================  Files         159      158       -1       Lines        9226     9224       -2       Branches       73       73              ==========================================+ Hits         6287     6295       +8+ Misses       2317     2310       -7+ Partials      622      619       -3
FlagCoverage Δ
unittest-go-macos-latest62.82% <ø> (+0.15%)⬆️
unittest-go-ubuntu-latest67.43% <ø> (-0.03%)⬇️
unittest-go-windows-202262.22% <ø> (ø)
unittest-js64.23% <ø> (+0.16%)⬆️
Impacted FilesCoverage Δ
peer/conn.go80.81% <0.00%> (-0.77%)⬇️
site/.storybook/preview.js
coderd/provisionerdaemons.go57.60% <0.00%> (+0.54%)⬆️
peerbroker/listen.go83.89% <0.00%> (+2.54%)⬆️
codersdk/provisionerdaemons.go61.53% <0.00%> (+3.07%)⬆️
provisionersdk/serve.go43.24% <0.00%> (+8.10%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update97399f8...54e2cc8. Read thecomment docs.

@bryphe-coder
Copy link
ContributorAuthor

Agree 100% with your comments@vapurrmaid - I logged#444 to track investigate bringing Chromatic back.

@bryphe-coderbryphe-coder merged commitdfc353b intomainMar 15, 2022
@bryphe-coderbryphe-coder deleted the bryphe/fix/storybook-build branchMarch 15, 2022 18:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kylecarbskylecarbskylecarbs approved these changes

+1 more reviewer

@greyscaledgreyscaledgreyscaled approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bryphe-coder@greyscaled@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp