Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: deployment flags#4426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
f0ssel merged 11 commits intomainfromf0ssel/new-flags
Oct 10, 2022
Merged

feat: deployment flags#4426

f0ssel merged 11 commits intomainfromf0ssel/new-flags
Oct 10, 2022

Conversation

f0ssel
Copy link
Contributor

@f0sself0ssel commentedOct 7, 2022•
edited
Loading

This moves all of the flags used to configurecoder server into a centralized structcodersdk.DeploymentFlags that is now also returned by the api at/api/v2/flags/deployment. We scrub secret values out before returning them on the API and the endpoint currently only authorized the builtinowner role.

This satisfies the backend portion of#4203.

Future work

  • remove duplication of variables in the coderd API and use theDeploymentFlags field for conditional logic
  • use this format for a site-wide flag endpoint for regular users as well

@f0sself0ssel marked this pull request as ready for reviewOctober 10, 2022 17:27
@f0sself0ssel requested a review froma team as acode ownerOctober 10, 2022 17:27
@f0sself0ssel requested review fromKira-Pilot,kylecarbs anddeansheather and removed request fora teamOctober 10, 2022 17:27
@f0sself0ssel merged commitb1faaef intomainOct 10, 2022
@f0sself0ssel deleted the f0ssel/new-flags branchOctober 10, 2022 19:04
kylecarbs added a commit that referenced this pull requestOct 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

@deansheatherdeansheatherdeansheather approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@f0ssel@kylecarbs@deansheather@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp