Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: replace old ErrorSummary component#4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Kira-Pilot merged 3 commits intomainfromreplace-error-summary/kira-pilot
Oct 7, 2022

Conversation

Kira-Pilot
Copy link
Member

Since we introduced theAlertBanner, we can rip out the oldErrorSummary component and use that instead.

@Kira-PilotKira-Pilot requested a review froma team as acode ownerOctober 7, 2022 15:26
@Kira-PilotKira-Pilot requested review fromjsjoeio and removed request fora teamOctober 7, 2022 15:26
Copy link
Contributor

@jsjoeiojsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work! I didn't look at Chromatic but I assume you checked these and everything renders okay still?

@Kira-Pilot
Copy link
MemberAuthor

Nice work! I didn't look at Chromatic but I assume you checked these and everything renders okay still?

@jsjoeio thanks! yup,you can take a look here if you're curious. The expander caret is correctly positioned now.

jsjoeio reacted with hooray emoji

@Kira-PilotKira-Pilot merged commit257df81 intomainOct 7, 2022
@Kira-PilotKira-Pilot deleted the replace-error-summary/kira-pilot branchOctober 7, 2022 17:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jsjoeiojsjoeiojsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Kira-Pilot@jsjoeio
[8]ページ先頭
©2009-2025 Movatter.jp