- Notifications
You must be signed in to change notification settings - Fork928
feat: Add tunnel by default#4399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cli/server_test.go Outdated
| @@ -127,6 +129,7 @@ func TestServer(t *testing.T) { | |||
| "server", | |||
| "--in-memory", | |||
| "--address", ":0", | |||
| "--access-url", "example.com", | |||
| "--access-url", "localhost:3000/", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why provideaccess-url twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just an accident
(cc@endingwithali this affects docs) |
If an access URL is not specified, we will always tunnel.This is from community-member feedback who exclaimed thatit's confusing having the default for `coder server` displaya warning message, and I agree.There is very little (maybe none) in running `coder server`without tunnel and without an access URL, so this seems likeoverall a much better UX.
endingwithali commentedOct 6, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
yes! auto setting tunnel is a great idea. :) to 100% clarify - when running coder without an access url, you wont need to edit coder.env before running coder |
Great change 👍 |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| @@ -4,7 +4,7 @@ You can install and run Coder using the official Docker images published on [Git | |||
| Docker is required. See the [official installation documentation](https://docs.docker.com/install/). | |||
| ## Run Coder with built-in database and tunnel (quick) | |||
| ## Run Coder withthebuilt-in database (quick) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's still mention we're using the tunnel here, both are configured here based on the lack of flags.
I assume this change won't break existing deployments? |
Co-authored-by: Ben Potter <ben@coder.com>
Co-authored-by: Ben Potter <ben@coder.com>
kylecarbs commentedOct 6, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@ammario it won'tunless they aren't specifying an access URL, but even then it won't break them unless they are air-gapped and the tunnel will fail with a message indicating that an access URL should be specified. |
If an access URL is not specified, we will always tunnel.
This is from community-member feedback who exclaimed that it's confusing having the default for
coder serverdisplay a warning message, and I agree.There is very little (maybe none) in running
coder serverwithout tunnel and without an access URL, so this seems like overall a much better UX.