Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: fix apps being unavailable until rebuild#4395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromdean/fix-apps-subdomain
Oct 6, 2022
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
-- nothing
12 changes: 12 additions & 0 deletionscoderd/database/migrations/000056_app_subdomain_fix.up.sql
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
-- There was a mistake in the last migration which set "subdomain" to be the
-- opposite of the deprecated value "relative_path", however the "relative_path"
-- value may not have been correct as it was not consumed anywhere prior to this
-- point.
--
-- Force all workspace apps to use path based routing until rebuild. This should
-- not impact any existing workspaces as the only supported routing method has
-- been path based routing prior to this point.
--
-- On rebuild the value from the Terraform template will be used instead
-- (defaulting to false if unspecified).
UPDATE "workspace_apps" SET "subdomain" = false;
3 changes: 1 addition & 2 deletionsprovisioner/terraform/resources.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -235,7 +235,6 @@ func ConvertResources(module *tfjson.StateModule, rawGraph string) ([]*proto.Res
}
}

subdomain := attrs.Subdomain
for _, agents := range resourceAgents {
for _, agent := range agents {
// Find agents with the matching ID and associate them!
Expand All@@ -247,7 +246,7 @@ func ConvertResources(module *tfjson.StateModule, rawGraph string) ([]*proto.Res
Command: attrs.Command,
Url: attrs.URL,
Icon: attrs.Icon,
Subdomain:subdomain,
Subdomain:attrs.Subdomain,
Healthcheck: healthcheck,
})
}
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp